Draft
Conversation
- Split storage module into separate traits, types, errors, and implementations - Add conditional compilation for AWS SDK and object_store dependencies - Move S3 and ObjectStore implementations to implementations/ subdirectory - Provide WASM-compatible stubs for type compatibility - Keep core Storage trait and supporting types always available - Enable future WASM storage backend implementations 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First test at getting icechunk working on some combination of wasm and node. #356
Starting first with NAPI v3 and its new wasm-wasi support
icechunk-jscrate and build config@earthmover/icechunk